Skip to content

Update pytest-timeout to support python >= 3.12#314

Merged
jhamon merged 1 commit intopinecone-io:mainfrom
mjvankampen:fix/test-python-3.12
Feb 21, 2024
Merged

Update pytest-timeout to support python >= 3.12#314
jhamon merged 1 commit intopinecone-io:mainfrom
mjvankampen:fix/test-python-3.12

Conversation

@mjvankampen
Copy link
Copy Markdown
Contributor

Problem

I could not run unit tests because pytest-timeout relies on distutils which was removed in python 3.12

Solution

Updated pytest-timeout

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Run all unit tests. Does not impact the actual client.

@jhamon
Copy link
Copy Markdown
Collaborator

jhamon commented Feb 21, 2024

Looks good, thanks.

@jhamon jhamon merged commit 17b33e7 into pinecone-io:main Feb 21, 2024
@mjvankampen mjvankampen deleted the fix/test-python-3.12 branch February 26, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants